Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internals] Move EventManager to @mui/x-internals package #13815

Merged
merged 3 commits into from
Jul 12, 2024

Conversation

flaviendelangle
Copy link
Member

The Tree View package was using an exact replicate of the grid Event Manager class.
I think it's safe to add this to the shared package to save some bundle size.

About the PR title, I went for internals for everything related to this package, feel free to propose another one.

@flaviendelangle flaviendelangle added the core Infrastructure work going on behind the scenes label Jul 12, 2024
@flaviendelangle flaviendelangle self-assigned this Jul 12, 2024
@mui-bot
Copy link

mui-bot commented Jul 12, 2024

Deploy preview: https://deploy-preview-13815--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against fa2a557

Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@flaviendelangle flaviendelangle merged commit 4765a52 into mui:master Jul 12, 2024
15 checks passed
@flaviendelangle flaviendelangle deleted the internals-EventManager branch July 12, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants