[charts] Disable animations while zooming #13807
Conversation
JCQuintas
added
enhancement
|
Deploy preview: https://deploy-preview-13807--material-ui-x.netlify.app/ |
github-actions
bot
added
the
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
JCQuintas
force-pushed
the
fix-zoom-animations
branch
from
cb54b4c
to
ad5516a
Compare
github-actions
bot
removed
the
PR: out-of-date
| interactionTimeoutRef.current = window.setTimeout(() => { | ||
| setIsInteracting(false); | ||
| }, 166); |
There was a problem hiding this comment.
Is 166 a magic number? 🧙♂️
More seriously, what's the reason for this timeout?
There was a problem hiding this comment.
It came from the mui/utils/debounce. It is 10 frames at 60hz apparently. We can probably remove it or make it smaller, since the timeout will run in a new cycle anyways. We just can't have setZoomData(newZoomData); and setIsInteracting(false); together because react bundles them up
There was a problem hiding this comment.
Also, this is a wheel event, so there is no "wheelup" for us to turn the toggle off. So we pretty much reset the timer if we have another wheel event and after a few ms we reset it to false again.
There was a problem hiding this comment.
Maybe a comment
// Debounce transition to `isInteractive=false`.
// Useful for wheel events which doesn't have an end event
Signed-off-by: Jose C Quintas Jr <[email protected]>
Remove the animations while zooming the chart.