Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Add more conformance tests improving API docs precision #13800

Merged
merged 14 commits into from
Jul 12, 2024
Merged

[pickers] Add more conformance tests improving API docs precision #13800

merged 14 commits into from
Jul 12, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jul 10, 2024 •
edited
Loading

It's a follow-up on #13780 after discovering such oversights.

  • ℹ️ Fix PickersLayout ref handling
    • Fixes passing ref to Static Pickers
  • Increase existing tests describeConformance coverage
  • Rename a few test files to allow for docs:api parsing
  • Add missing conformance tests to Picker components
  • Add PickersRangeCalendarHeader test
  • Add PickersCalendarHeader test
  • Add PickersArrowSwitcher test
    • when adding the test it was apparent that some slots are missing specific unique classes

@LukasTy LukasTy added docs Improvements or additions to the documentation test typescript component: pickers This is the name of the generic UI component, not the React module! labels Jul 10, 2024
@LukasTy LukasTy self-assigned this Jul 10, 2024
@mui-bot
Copy link

mui-bot commented Jul 10, 2024 •
edited
Loading

Deploy preview: https://deploy-preview-13800--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 47213c9

flaviendelangle
flaviendelangle approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 so many small problems catched

@LukasTy LukasTy merged commit bb50cc1 into mui:master Jul 12, 2024
17 checks passed
@LukasTy LukasTy deleted the add-more-conformance-tests branch July 12, 2024 11:21
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
@LukasTy @DungTiger
[pickers] Add more conformance tests improving API docs precision (mu…
5df2fa4 
…i#13800)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle flaviendelangle approved these changes

@arthurbalduini arthurbalduini Awaiting requested review from arthurbalduini

Assignees

@LukasTy LukasTy

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation test typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LukasTy @mui-bot @flaviendelangle