Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Reuse useReactVersion script from the monorepo #13710

Merged
merged 14 commits into from
Jul 22, 2024

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Jul 2, 2024

@cherniavskii cherniavskii added the scope: code-infra Specific to the core-infra product label Jul 2, 2024
@mui-bot
Copy link

mui-bot commented Jul 2, 2024

Deploy preview: https://deploy-preview-13710--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 550d6b6

Copy link

github-actions bot commented Jul 4, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 4, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 17, 2024
@cherniavskii cherniavskii marked this pull request as ready for review July 17, 2024 21:25
@cherniavskii cherniavskii changed the title [code-infra] reuse useReactVersion script from the monorepo [code-infra] Reuse useReactVersion script from the monorepo Jul 22, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 22, 2024
@@ -89,7 +90,7 @@
"@mui/internal-markdown": "^1.0.7",
"@mui/internal-test-utils": "^1.0.4",
"@mui/material": "^5.16.2",
"@mui/monorepo": "github:mui/material-ui#0d9333e9f3999d96679a2691e2815296a81475f2",
"@mui/monorepo": "github:mui/material-ui#288863bd2f8681a82c4bfbaf13215b41043bc551",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 22, 2024
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

We can remove the script once we'll add a bin to the monorepo package.json

@cherniavskii cherniavskii merged commit 3698841 into mui:master Jul 22, 2024
18 of 21 checks passed
@cherniavskii cherniavskii deleted the useReactVersion-monorepo branch July 22, 2024 15:24
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants