Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Limit the trigger of exit charts #13682

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

alexfauquette
Copy link
Member

Fix #13659

@alexfauquette alexfauquette added the component: charts This is the name of the generic UI component, not the React module! label Jul 1, 2024
@mui-bot
Copy link

mui-bot commented Jul 1, 2024

Deploy preview: https://deploy-preview-13682--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 3940f64

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 18, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@alexfauquette alexfauquette marked this pull request as ready for review July 19, 2024 09:06
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jul 19, 2024
Copy link
Member

@JCQuintas JCQuintas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just a small change for the param name

packages/x-charts/src/context/DrawingProvider.tsx Outdated Show resolved Hide resolved
Co-authored-by: Jose C Quintas Jr <[email protected]>
Signed-off-by: Alexandre Fauquette <[email protected]>
@alexfauquette alexfauquette merged commit b58554c into mui:master Jul 19, 2024
17 checks passed
@alexfauquette alexfauquette deleted the fix-13659 branch July 19, 2024 13:52
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
Signed-off-by: Alexandre Fauquette <[email protected]>
Co-authored-by: Jose C Quintas Jr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[charts] Tooltips for points on the edge of the chart are not always shown with tooltip trigger item
3 participants