Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Export Pro versions of regular charts #13547

Merged
merged 12 commits into from
Jun 20, 2024

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Jun 19, 2024

  • Export BarChartPro
  • Export LineChartPro
  • Export ScatterChartPro

???

  • Should we export PieChartPro?

related #13405

@JCQuintas JCQuintas self-assigned this Jun 19, 2024
@JCQuintas JCQuintas added the component: charts This is the name of the generic UI component, not the React module! label Jun 19, 2024
@mui-bot
Copy link

mui-bot commented Jun 19, 2024

Deploy preview: https://deploy-preview-13547--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 43a0f49

@alexfauquette
Copy link
Member

Should we export PieChartPro?

Since it's not impacted by the zooming, I propose do don't create it for now

@alexfauquette
Copy link
Member

What do you think about an internal useBarChartProps(props) that returns an object {containerProps, barPlotProps, overlayProps, axisProps, ...}?

Like that we would be sure that props propagation in the community and pro package keep in sync.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 19, 2024
@JCQuintas
Copy link
Member Author

What do you think about an internal useBarChartProps(props) that returns an object {containerProps, barPlotProps, overlayProps, axisProps, ...}?

Like that we would be sure that props propagation in the community and pro package keep in sync.

🤔 can try it out

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 20, 2024
@alexfauquette
Copy link
Member

The scatter chart experiment seems promising 🚀

@JCQuintas
Copy link
Member Author

@alexfauquette should be ready for review again

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the CI (some empty lines removed by pnpm proptypes)

I also removed the proptypes of the pro components, because they are not generated for now.

THis will be availabel after uncommenting this : https://github.com/mui/mui-x/blob/master/docs/scripts/createXTypeScriptProjects.ts/#L320-L337

packages/x-charts/src/BarChart/useBarChartProps.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants