[docs] Improve the documentation of the picker's onChange and onAccept props
#13543
Conversation
flaviendelangle
added
docs
|
Deploy preview: https://deploy-preview-13543--material-ui-x.netlify.app/ Updated pages: |
flaviendelangle
force-pushed
the
context-doc
branch
from
1b1ea2c
to
ad996b0
Compare
|
|
||
| :::info | ||
| In all the below scenarios, the picker closes when `onClose` is called, except if you are controlling the `open` prop. | ||
| ::: | ||
|
|
||
| #### When the last view is completed | ||
| ##### When the last view is completed |
There was a problem hiding this comment.
How do you feel about this h5?
To me, the resulting structure doesn't look the best. 🙈
Maybe that is the reason why we don't have h5 anywhere in the docs? 🤔
There was a problem hiding this comment.
How do you think we could avoid it?
- Replace the current h5 with bullet points?
- Remove the current h2 and move its information to the current h3?
- Keep the current h4 as direct child of the current h3 (do not add the "When is XXX called?" level)?
- something else?
There was a problem hiding this comment.
I'm in favor of 2nd or 3rd option, but 2nd one doesn't feel right given the current page structure (fields lifecycle, pickers lifecycle).
This technically leaves us with 3rd option, I don't have any better suggestion without refactoring the page structure. 🤔
There was a problem hiding this comment.
We can consider refactoring the page structure if it allows to have a better result.
| @@ -44,13 +44,15 @@ Note how changing the value of the start date section will call `onChange` even | |||
|
|
|||
| ## Pickers lifecycle | |||
|
|
|||
| ### When is `onClose` called? | |||
| ### `onClose` | |||
There was a problem hiding this comment.
WDYT about dropping the code block for these headings where the callback is the only word? 🤔
| ### `onClose` | |
| ### onClose |
Follow up on #13511