Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] POC Support BarChart with scaletype time #13454

Conversation

JCQuintas
Copy link
Member

@JCQuintas JCQuintas commented Jun 11, 2024

Concept

We could technically create conditional behaviour to handle time series in the bar chart.

Issues

There some issues with the current changes:

  • Bar offset is kinda wrong
  • The padding is currently fixed to 1px, but it should be adjustable, which is different from band type where it uses a "ratio"

Example: https://codesandbox.io/p/sandbox/barchart-scale-time-xkw9ln?file=%2Fsrc%2Fdemo.tsx%3A5%2C4

resolves #12537

@JCQuintas JCQuintas added the component: charts This is the name of the generic UI component, not the React module! label Jun 11, 2024
@JCQuintas JCQuintas self-assigned this Jun 11, 2024
@mui-bot
Copy link

mui-bot commented Jun 11, 2024

Deploy preview: https://deploy-preview-13454--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2f11ab8

@JCQuintas JCQuintas marked this pull request as draft June 12, 2024 08:20
@alexfauquette
Copy link
Member

@JCQuintas I can't access the codesandbox. They introduced the notion of private sandbox recently. Maybe you should move this one to public

@JCQuintas
Copy link
Member Author

Will be closing this in favour of #13471

@JCQuintas JCQuintas closed this Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Charts] Support BarChart with scaleType: time
3 participants