Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Support date and datetime-local input types in GridFilterInputMultipleValue type #13411

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

karudedios
Copy link
Contributor

Description

When using type = date or type = datetime-local the prop types on GridFilterInputMultipleValue produce an error despite actually working perfectly fine given that this component (by default) just uses a native input.

This change is also consistent with how GridFilterInputValue handles this property's typing (except there's no enum enforcement in the prop types over there, for some reason).

Please do let me know if I missed something, the change in the prop-types/types seemed trivial enough to do by hand, but if I must clone this and and run pnpm prototype to have the codegen do it for me I can, I had just chosen to take the easy way and directly edited this in GitHub.

Fixes #13409

From the template

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Jun 7, 2024
Copy link
Member

@michelengelen michelengelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... but I would like to know from the team if this would maybe have unforeseen effects elsewhere

@flaviendelangle flaviendelangle changed the title [chore] update type and propType enum for GridFilterInputMultipleValue [core] update type and propType enum for GridFilterInputMultipleValue Jun 17, 2024
@cherniavskii cherniavskii changed the title [core] update type and propType enum for GridFilterInputMultipleValue [DataGrid] Support date and datetime-local input types in GridFilterInputMultipleValue type Jul 10, 2024
@cherniavskii cherniavskii added customization: extend Logic customizability typescript and removed bug 🐛 Something doesn't work labels Jul 10, 2024
@mui-bot
Copy link

mui-bot commented Jul 10, 2024

Deploy preview: https://deploy-preview-13411--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 38c5672

@arminmeh arminmeh merged commit 9d49261 into mui:master Jul 15, 2024
17 checks passed
@karudedios karudedios deleted the fix/13409 branch July 16, 2024 22:08
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
…lterInputMultipleValue` type (mui#13411)

Signed-off-by: Carlos De Dios <[email protected]>
Co-authored-by: Andrew Cherniavskyi <[email protected]>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
…lterInputMultipleValue` type (mui#13411)

Signed-off-by: Carlos De Dios <[email protected]>
Co-authored-by: Andrew Cherniavskyi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! customization: extend Logic customizability typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] GridFilterInputMultipleValue's prop types are incorrectly typed
6 participants