[DataGrid] Support date and datetime-local input types in GridFilterInputMultipleValue type
#13411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karudedios
commented
Jun 7, 2024
packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputMultipleValue.tsx
Outdated
Show resolved
Hide resolved
type and propType enum for GridFilterInputMultipleValuetype and propType enum for GridFilterInputMultipleValue
type and propType enum for GridFilterInputMultipleValuedate and datetime-local input types in GridFilterInputMultipleValue type
Signed-off-by: Carlos De Dios <[email protected]>
…erInputMultipleValue.tsx Signed-off-by: Carlos De Dios <[email protected]>
|
Deploy preview: https://deploy-preview-13411--material-ui-x.netlify.app/ |
arminmeh
approved these changes
Jul 15, 2024
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
…lterInputMultipleValue` type (mui#13411) Signed-off-by: Carlos De Dios <[email protected]> Co-authored-by: Andrew Cherniavskyi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using
type = dateortype = datetime-localthe prop types onGridFilterInputMultipleValueproduce an error despite actually working perfectly fine given that this component (by default) just uses a native input.This change is also consistent with how GridFilterInputValue handles this property's typing (except there's no enum enforcement in the prop types over there, for some reason).
Please do let me know if I missed something, the change in the prop-types/types seemed trivial enough to do by hand, but if I must clone this and and run
pnpm prototypeto have the codegen do it for me I can, I had just chosen to take the easy way and directly edited this in GitHub.Fixes #13409
From the template