[core] Fix eslint no-restricted-imports rule application
#13401
Conversation
|
Deploy preview: https://deploy-preview-13401--material-ui-x.netlify.app/ |
flaviendelangle
force-pushed
the
lint-imports
branch
from
bfd45e5
to
82a10c8
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
| @@ -1,7 +1,7 @@ | |||
| import * as React from 'react'; | |||
| import Box from '@mui/material/Box'; | |||
| import Rating from '@mui/material/Rating'; | |||
| import { unstable_useEnhancedEffect as useEnhancedEffect } from '@mui/utils'; | |||
| import useEnhancedEffect from '@mui/utils/useEnhancedEffect'; | |||
There was a problem hiding this comment.
This modification looks weird, because nothing indicates that this hook is unstable.
Not an issue in the package code, but it the docs, I'm not sure
There was a problem hiding this comment.
One could say that we should not even use @mui/utils in the doc since it's meant to be an internal package, but we are doing it extensively 😬
There was a problem hiding this comment.
Problem solved? 😁
| import useEnhancedEffect from '@mui/utils/useEnhancedEffect'; | |
| import unstable_useEnhancedEffect from '@mui/utils/useEnhancedEffect'; |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
|
|
||
| // Rules only impacting bundled files and doc files | ||
| { | ||
| files: ['packages/*/src/**/*{.ts,.tsx,.js}', 'docs/data/**/*{.ts,.tsx,.js}'], |
There was a problem hiding this comment.
I suspect that we don't need this. This should be coming from the monorepo root eslint configuration since there doesn't seem to be anything specific about MUI X.
| files: ['packages/*/src/**/*{.ts,.tsx,.js}', 'docs/data/**/*{.ts,.tsx,.js}'], |
I think the recent changes broke the linting because
no-restricted-importsdoes not work well when applied several time (the last one tends to override the previous ones).@mui/utilsroot in all our packages / doc / test files@mui/materialroot in all our packages / doc / test filesimport { DateRange } from '@mui/x-date-pickers/internals/models') in all our packages / doc files (the test files can do it to avoid exporting stuff just because some test uses it@LukasTy if you see any weird behavior I'm of course interested, I tested a few imports and it seems to be consistent