[charts] Add watermark on the pro ResponsiveChartContainer

[alexfauquette]

I'm hesitating between reexporting the container like I'm currently doing (<ResponsiveChartContainer />), or exporting them with a pro suffix <ResponsiveChartContainerPro />.

@flaviendelangle Do you have some insight on this aspect? the reexport only add watermark, and it's still unsure if we will add behavior to this component

[mui-bot]

Deploy preview: https://deploy-preview-13398--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 57a4e78

[flaviendelangle]

I'm hesitating between reexporting the container like I'm currently doing (), or exporting them with a pro suffix .

Sorry but I don't understand the difference 😆

[alexfauquette]

Sorry but I don't understand the difference 😆

😅 Effectively, I copy pasted the same

• ResponsiveChartContainer: current solution (same naming but component with a watermark)
• ResponsiveChartContainerPro: other solution (different naming but only user-facing difference is the watermark)

[JCQuintas]

We should probably follow what the other packages do

[JCQuintas]

But I noticed each package does a different thing 😅

[JCQuintas]

I would probably go with the DataGrid solution if we want to always load the new functionalities on the Pro package. This means disallowing the use of ResponsiveChartContainer

[flaviendelangle]

If people need to use the pro version (which is the case here), I'd keep the Pro suffix to avoid confusion and somehow prevent users from user the community one.

[flaviendelangle]

But I noticed each package does a different thing 😅

Yeah, it's hard to be 100% consistent on this topic, the trade-off vary greatly across the packages.
Calling the grid DataGrid on all the packages would not be nice, but on the other hand calling the range picker DateRangePickerPro when it has no free version is super heavy.

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[JCQuintas]

Looks good, should we also block the use of the ResponsiveChartContainer?

[alexfauquette]

should we also block the use of the ResponsiveChartContainer?

The ResponsiveChartContainer and ChartContainer are not exported by the @mui/x-charts-pro 👍