[DataGridPro] Keep bottom pinned row at the bottom #13313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-13313--material-ui-x.netlify.app/ |
KenanYusuf
approved these changes
Jun 4, 2024
MBilalShafi
reviewed
Jun 5, 2024
packages/x-data-grid/src/components/virtualization/GridVirtualScroller.tsx
Outdated
Show resolved
Hide resolved
cherniavskii
approved these changes
Jun 19, 2024
romgrk
commented
Jun 19, 2024
Comment on lines
-516
to
-524
| // In cases where the columns exceed the available width, | ||
| // the horizontal scrollbar should be shown even when there're no rows. | ||
| // Keeping 1px as minimum height ensures that the scrollbar will visible if necessary. | ||
| const height = Math.max(contentHeight, 1); | ||
|
|
There was a problem hiding this comment.
I think this code was preventing this 0-height warning from running in some cases, so fixing it broke some tests all over the place that didn't have explicit dimensions on the grid container. I'll need to debug & update those tests before merging this PR. The test runner also doesn't seem to match the warning to which test it originated from precisely, so sometimes it marks one test as failed but the warning came from another test. As in if I run the test with .only it succeeds, but if I run the test suite as a whole it fails. Lots of fun ahead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12925
Before: https://codesandbox.io/p/sandbox/funny-leaf-6fv4qt
After: https://codesandbox.io/p/sandbox/mui-mui-x-x-data-grid-forked-9vpwwk