Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Restore t command #12948

Merged
merged 3 commits into from
May 1, 2024
Merged

[test] Restore t command #12948

merged 3 commits into from
May 1, 2024

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Apr 30, 2024

Fixes #12935

Related to mui/material-ui#40430

Core repo PR description:

This change restores the pre-pnpm behavior of the t script.
With yarn, it was possible to run the test CLI by executing yarn t <test-pattern>. However, pnpm treats t as an alias for test. I introduced a small script that's run whenever pnpm t or pnpm test is executed. It checks if it has any arguments and calls either the test CLI (previous yarn t) or the extended validation suite (previously yarn test)

@LukasTy LukasTy added test core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product labels Apr 30, 2024
@LukasTy LukasTy self-assigned this Apr 30, 2024
@mui-bot
Copy link

mui-bot commented Apr 30, 2024

Deploy preview: https://deploy-preview-12948--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 61e1a8f

@LukasTy LukasTy marked this pull request as ready for review April 30, 2024 13:43
@LukasTy LukasTy requested review from michelengelen and a team April 30, 2024 13:43
@JCQuintas
Copy link
Member

JCQuintas commented Apr 30, 2024

Shouldn't we just use pnpm run test --? 😅 seems a script for this is a bit overkill.

Or pnpm run t -- depending on your use-case

@LukasTy
Copy link
Member Author

LukasTy commented Apr 30, 2024

Shouldn't we just use pnpm run test --? 😅 seems a script for this is a bit overkill.

You can use whatever you are most comfortable with.
This is mainly to be in line with the Contributing guidelines, which are directly "inherited" from the mui/material-ui.
Personally, I almost exclusively use test:unit --grep <whateverIWantToTest>. 🤷

@LukasTy LukasTy merged commit c9c7fad into mui:master May 1, 2024
17 checks passed
@LukasTy LukasTy deleted the fix-test-command branch May 1, 2024 07:34
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: code-infra Specific to the core-infra product test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[code-infra] "pnpm test" works poorly
3 participants