[DataGrid] Pass reason to onPaginationModelChange
#12923
Conversation
Signed-off-by: Michel Engelen <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]>
Signed-off-by: Gene Arch <[email protected]> Co-authored-by: Rom Grk <[email protected]>
|
Deploy preview: https://deploy-preview-12923--material-ui-x.netlify.app/ |
file: [packages\x-data-grid\src\hooks\features\pagination\useGridPaginationModel.ts] (+) updated setPaginationModel api.current.setState to set the reason, 'setPaginationModel'. this was removed in commit 7c4ba74.
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
packages/x-data-grid-premium/src/hooks/features/aggregation/gridAggregationInterfaces.ts
Show resolved
Hide resolved
packages/x-data-grid/src/hooks/features/pagination/useGridPaginationModel.ts
Show resolved
Hide resolved
onPaginationModelChange
file: [packages\x-data-grid\src\hooks\features\pagination\useGridPaginationModel.ts] (+) updated setPaginationModel api.current.setState to set the reason, 'setPaginationModel'. this was removed in commit 7c4ba74.
6373509
to
12ce10c
Compare
|
@cherniavskii Seems no activity here, I just created a new PR here |
|
I haven't had time to revisit, thank you for the reminder. I suggest that we merge your recommended changes into this branch to save on PRs. |
file: [packages\x-data-grid\src\hooks\features\pagination\useGridPaginationModel.ts] (+) added stateRestorePreProcessing message to setState in stateRestorePreProcessing function. file: [packages\x-data-grid\src\models\props\DataGridProps.ts] (+) updated typing for onPaginationModelChange callback.
|
@DungTiger I believe I have integrated your changes into my branch and PR. Thank you for the support! Let me know if you have thoughts or questions. |
|
@bjackson42 I think you need to rebase your changes on latest |
|
Thank you, hopefully I didn't goof that. I followed the instructions that were provided for making a PR and checked what I committed after the push. I see the changes that you and I have made (2 files), one that @cherniavskii made (1 file), and it looks like another slight update made it into the change list. Perhaps @cherniavskii can verify that everything is sanitized? |
|
Hello, this looks quite stale. Any updates on getting this merged ? |
Fixes #12897