[test] Use test-utils from npm #12880

michaldudak · 2024-04-23T12:23:20Z

Using test-utils from an npm package instead of monorepo.

A couple of additional changes were needed:

tsconfig's moduleResolution was set to bundler to enable reading package.json exports field
@testing-library/react was upgraded to 15.0.7 to match the version from the test-utils
@types/react-dom were upgraded to 18.2.25 (the previous version did not contain a type used by testing-library)

To be merged after mui/material-ui#41177 is merged and published.

github-actions · 2024-04-24T15:09:36Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

mui-bot · 2024-05-27T10:00:50Z

Deploy preview: https://deploy-preview-12880--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against b45fcc3

LukasTy

Nice! 👏

pnpm-lock.yaml

michaldudak · 2024-05-27T15:26:34Z

The failing tests are most likely not related to this PR, as they also fail when the monorepo is updated to next (#13086). The out-of-memory error on CI is a bit worrying, though.

I'd appreciate any assistance with these.

LukasTy · 2024-05-29T06:06:19Z

It's clear that the explicit memory limit increase is needed as before it the CPU is pegged doing too much GC. 🙈

Before

After

github-actions · 2024-05-29T07:10:36Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

michaldudak · 2024-05-29T08:46:57Z

mui/material-ui#41177 has been merged and @mui/internal-test-utils is published to npm with version 1.0.0-dev.20240529-082515-213b5e33ab

LukasTy · 2024-05-29T09:20:04Z

renovate.json

@@ -6,7 +6,7 @@
 "commitMessageTopic": "{{depName}}",
 "dependencyDashboard": true,
 "rebaseWhen": "conflicted",
- "ignoreDeps": ["jsdom"],
+ "ignoreDeps": [],


@cherniavskii On the latest major they reverted a change that initially reduced the performance
https://github.com/jsdom/jsdom/releases/tag/24.0.0

LukasTy

LGTM! 👏
Thanks for the effort. 💙

I've also updated jsdom and ran dedupe to reduce amount of duplicate packages, which were introduced for some reason. 🙈

Do you have any idea why argos reacted like there is no reference build and treats all screenshots as new? 🤔 🤷

michaldudak · 2024-05-29T10:04:25Z

Do you have any idea why argos reacted like there is no reference build and treats all screenshots as new? 🤔 🤷

It looks like an issue on Argos' side. I started seeing it in other PRs as well.

cherniavskii · 2024-05-29T12:33:45Z

package.json

@@ -32,7 +32,7 @@
 "size:why": "pnpm size:snapshot --analyze --accurateBundles",
 "tc": "node test/cli.js",
 "test": "node scripts/test.mjs",
- "test:coverage": "cross-env NODE_ENV=test TZ=UTC BABEL_ENV=coverage nyc mocha --exclude '**/node_modules/**' && nyc report -r lcovonly",
+ "test:coverage": "cross-env NODE_OPTIONS=--max-old-space-size=4096 NODE_ENV=test TZ=UTC BABEL_ENV=coverage nyc mocha --exclude '**/node_modules/**' && nyc report -r lcovonly",


@LukasTy How did you manage to make the test_unit pass? It failed even when I added this flag here

Did it? I saw them passing even before bumping jsdom... 🤷
https://app.circleci.com/pipelines/github/mui/mui-x?branch=pull%2F12880

Ahh, I think I didn't wait for the result after my last commit, and for some reason assumed it failed 😅
All good then 👍🏻

P.S. Here is my comment comparing your commits behavior on the system resources. 😉
#12880 (comment)

AviVahl · 2024-05-30T16:17:36Z

packages/x-data-grid/package.json

@@ -48,6 +48,7 @@
 },
 "dependencies": {
 "@babel/runtime": "^7.24.5",
+ "@mui/internal-test-utils": "1.0.0-dev.20240529-082515-213b5e33ab",


@LukasTy this was added as a dependency, causing consumers to get this, and many others deps, installed.
this addition causes peerDep errors (about babel missing and react@18 not supported) on our end.

Thank you for raising this! 🙏
An issue has also been created for it: #13317.

@AviVahl A fixed package (v7.6.1) has been released: https://www.npmjs.com/package/@mui/x-data-grid?activeTab=versions

Co-authored-by: Andrew Cherniavskyi <[email protected]> Co-authored-by: Lukas <[email protected]>

[test] Use test-utils from npm

094edc5

michaldudak added test scope: code-infra Specific to the core-infra product labels Apr 23, 2024

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Apr 24, 2024

michaldudak added 2 commits May 27, 2024 11:56

Merge remote-tracking branch 'upstream/master' into test-utils-package

c39f013

Use the latest version

0ca006c

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 27, 2024

michaldudak added 2 commits May 27, 2024 12:30

Fix improper type

005d3f7

Fix type issues

43721f6

michaldudak requested review from LukasTy and alexfauquette May 27, 2024 13:50

Fix

a4e42e4

LukasTy reviewed May 27, 2024

View reviewed changes

pnpm-lock.yaml Show resolved Hide resolved

pnpm-lock.yaml Outdated Show resolved Hide resolved

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 28, 2024

This comment was marked as resolved.

Sign in to view

Merge branch 'master' into test-utils-package

3d0c1e8

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 28, 2024

cherniavskii added 2 commits May 29, 2024 00:05

try without max-old-space-size flag

d9eac53

pass max-old-space-size to test:coverage

727c95b

try jsdom bump

0640a16

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024

michaldudak added 2 commits May 29, 2024 10:36

Merge branch 'master' into test-utils-package

5f5167d

Update test-utils to the published version

1f4b143

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024

michaldudak marked this pull request as ready for review May 29, 2024 08:45

Remove jsdom renovate dep ignore

37d629b

LukasTy reviewed May 29, 2024

View reviewed changes

dedupe

b45fcc3

LukasTy approved these changes May 29, 2024

View reviewed changes

LukasTy merged commit 7269ea0 into mui:master May 29, 2024
17 checks passed

cherniavskii reviewed May 29, 2024

View reviewed changes

michaldudak deleted the test-utils-package branch May 29, 2024 13:10

AviVahl reviewed May 30, 2024

View reviewed changes

LukasTy mentioned this pull request Jun 14, 2024

Bump internal packages #13479

Merged

Rossen27 mentioned this pull request Jun 22, 2024

[Snyk] Upgrade @mui/x-tree-view from 7.3.1 to 7.6.1 Rossen27/Shopit-V1#81

Open

DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024

[test] Use test-utils from npm (mui#12880)

b452dd5

Co-authored-by: Andrew Cherniavskyi <[email protected]> Co-authored-by: Lukas <[email protected]>

thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024

[test] Use test-utils from npm (mui#12880)

0339b0f

Co-authored-by: Andrew Cherniavskyi <[email protected]> Co-authored-by: Lukas <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[test] Use test-utils from npm #12880

[test] Use test-utils from npm #12880

michaldudak commented Apr 23, 2024 •

edited

Loading

github-actions bot commented Apr 24, 2024

mui-bot commented May 27, 2024 •

edited

Loading

LukasTy left a comment

michaldudak commented May 27, 2024 •

edited

Loading

This comment was marked as resolved.

LukasTy commented May 29, 2024

github-actions bot commented May 29, 2024

michaldudak commented May 29, 2024

LukasTy May 29, 2024

LukasTy left a comment

michaldudak commented May 29, 2024

cherniavskii May 29, 2024

LukasTy May 29, 2024

cherniavskii May 29, 2024

LukasTy May 29, 2024

AviVahl May 30, 2024 •

edited

Loading

LukasTy May 30, 2024

LukasTy May 31, 2024

[test] Use test-utils from npm #12880

[test] Use test-utils from npm #12880

Conversation

michaldudak commented Apr 23, 2024 • edited Loading

github-actions bot commented Apr 24, 2024

mui-bot commented May 27, 2024 • edited Loading

LukasTy left a comment

Choose a reason for hiding this comment

michaldudak commented May 27, 2024 • edited Loading

This comment was marked as resolved.

LukasTy commented May 29, 2024

Before

After

github-actions bot commented May 29, 2024

michaldudak commented May 29, 2024

LukasTy May 29, 2024

Choose a reason for hiding this comment

LukasTy left a comment

Choose a reason for hiding this comment

michaldudak commented May 29, 2024

cherniavskii May 29, 2024

Choose a reason for hiding this comment

LukasTy May 29, 2024

Choose a reason for hiding this comment

cherniavskii May 29, 2024

Choose a reason for hiding this comment

LukasTy May 29, 2024

Choose a reason for hiding this comment

AviVahl May 30, 2024 • edited Loading

Choose a reason for hiding this comment

LukasTy May 30, 2024

Choose a reason for hiding this comment

LukasTy May 31, 2024

Choose a reason for hiding this comment

michaldudak commented Apr 23, 2024 •

edited

Loading

mui-bot commented May 27, 2024 •

edited

Loading

michaldudak commented May 27, 2024 •

edited

Loading

AviVahl May 30, 2024 •

edited

Loading