[TreeView] Remove un-needed aria-activedescendant attribute
#12867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aria-activedescendant attribute
|
Deploy preview: https://deploy-preview-12867--material-ui-x.netlify.app/ Updated pages: |
LukasTy
approved these changes
Apr 22, 2024
There was a problem hiding this comment.
LGTM. 👍
Unless we consider this to be a BC LukasTy? 🤔
IMHO this is a BC as some users might have relied on this feature for their tests or some other behavior based on previous versions' behavior. 🙈
Given that the change of behavior has been delivered as a BC with v7, then it would be safer to delay this change until v8.
On the other hand, I reckon that the amount of people this would impact is completely negligible. 😆
DungTiger
pushed a commit
to DungTiger/mui-x
that referenced
this pull request
Jul 23, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12494
Unless we consider this to be a BC @LukasTy? 🤔