Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Round y values for bar chart #12846

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Apr 19, 2024

Seems that rounding the px coordinate of the stack bars is better to avoid weird overlapping

@alexfauquette alexfauquette added the component: charts This is the name of the generic UI component, not the React module! label Apr 19, 2024
@mui-bot
Copy link

mui-bot commented Apr 19, 2024

Deploy preview: https://deploy-preview-12846--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against e27ed17

@alexfauquette alexfauquette marked this pull request as ready for review April 25, 2024 09:31
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the existing solution causes issues. 👍

@alexfauquette alexfauquette merged commit bd6cb52 into mui:master Apr 25, 2024
17 of 18 checks passed
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants