[fields] Support trailing zeros on section with ordinal when the ordinal is empty #12688
+373
−160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-12688--material-ui-x.netlify.app/ |
cabcd3d
to
0920f3b
Compare
flaviendelangle
commented
Apr 5, 2024
| section.contentType === 'digit' && | ||
| !hasLeadingZeros && | ||
| value.length === 1; | ||
| const shouldAddInvisibleSpace = ['input-rtl', 'input-ltr'].includes(target) && value.length === 1; |
There was a problem hiding this comment.
Small behavior change here, I'm adding the hidden character whenever the section is only 1 char long, otherwise it does not work for the bug in the linked issue
03760fc
to
096fde1
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12678