[charts] Allows series ids to be numbers #11941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview: https://deploy-preview-11941--material-ui-x.netlify.app/ Updated pages: |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
michelengelen
approved these changes
Feb 6, 2024
Comment on lines
-9
to
+10
| ): { | ||
| [id: string]: ISeries & { | ||
| valueFormatter: IFormatter; | ||
| }; | ||
| } { | ||
| const defaultizedSeries: { | ||
| [id: string]: ISeries & { | ||
| valueFormatter: IFormatter; | ||
| }; | ||
| } = {}; | ||
| ): Record<SeriesId, ISeries & { valueFormatter: IFormatter }> { | ||
| const defaultizedSeries: Record<SeriesId, ISeries & { valueFormatter: IFormatter }> = {}; |
There was a problem hiding this comment.
worth it for this alone ... so much more readible! 👍🏼
| x: number; | ||
| y: number; | ||
| /** | ||
| * A unique id identifying the scatter point. |
There was a problem hiding this comment.
nit to be consistent
Suggested change
| * A unique id identifying the scatter point. | |
| * A unique identifier for the scatter point. |
alexfauquette
added a commit
that referenced
this pull request
Feb 6, 2024
thomasmoon
pushed a commit
to thomasmoon/mui-x
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modification to be consistent with the data grid DevExp
The first commit is about moving
DefaultLegendin a dedicated file such that its proptypes are correctly generated and the API is extracted.The other ones are about using string and number for ids, and fixing ll the typescript implication it has