-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Uplift SimpleTreeView
customization examples
#11424
[docs] Uplift SimpleTreeView
customization examples
#11424
Conversation
Deploy preview: https://deploy-preview-11424--material-ui-x.netlify.app/ Updated pages: |
That's a big improvement over the current doc 👌 I liked a lot the "Adding borders" demo which is probably a very common use case I'm not a fan of the "Customizing for complex use cases" demo because it's a demo that display the power of our component when the others focus on a specific use-case. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, Nora — nice work! 👏 Just left a few notes about writing & the designs.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Hey, nice work @noraleonte! Echoing Flavien, I think the demos, though look nice, could be better placed or organized. I wonder if we could add an item such as "Customization" or "Styling" to the menu instead adding these demos to Overview, where we can populate it with demos and a playground in the future, like the styling page from Charts. |
This will be the case once the PR is merged with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking awesome, Nora — thanks for bearing with us on the review!
Just a round of fine-tune stuff :)
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: Nora <[email protected]>
…/mui-x into treeview-customization-uplift
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: Nora <[email protected]>
TreeView
customization examplesSimpleTreeView
customization examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome improvements of the doc!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a last round of touch-ups, but already dropping an approval! :)
Great work, Nora—thanks for pushing through!
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/customization.md
Outdated
Show resolved
Hide resolved
docs/data/tree-view/simple-tree-view/customization/BorderedTreeView.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: Nora <[email protected]>
…eView.tsx Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: Nora <[email protected]>
Changes:
Custom icons, borders and animation
demo -> split into more modular demos, highlighting each customization and gradually building up a more complex customized Tree ViewPreview:
https://deploy-preview-11424--material-ui-x.netlify.app/x/react-tree-view/simple-tree-view/customization/