Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] fix stray styles for marketing page #10921

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[DataGrid] fix stray styles for marketing page #10921

wants to merge 3 commits into from

Conversation

noraleonte
Copy link
Contributor

@noraleonte noraleonte commented Nov 6, 2023 •
edited
Loading

@noraleonte noraleonte added component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer labels Nov 6, 2023
@noraleonte noraleonte self-assigned this Nov 6, 2023
@mui-bot
Copy link

mui-bot commented Nov 6, 2023 •
edited
Loading

Deploy preview: https://deploy-preview-10921--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2301d8f

cherniavskii
cherniavskii reviewed Nov 6, 2023
View reviewed changes
packages/grid/x-data-grid-generator/src/renderer/renderProgress.tsx Outdated
Comment on lines 16 to 18
'&.low': {
backgroundColor: alpha('#FF505F', 0.1),
' .progress-bar': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I wonder what would be the idiomatic Emotion approach here to avoid global class names?
Styling background colors of Root and Bar separately in their own styled()?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a commit regarding this. Let me know what you think 😄

LukasTy
LukasTy reviewed Nov 7, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: I fear that this change has worse dark mode text contrast 🙈
Screenshot 2023-11-07 at 09 50 08

danilo-leal
danilo-leal approved these changes Nov 7, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some changes that hopefully address the contrast nicely! Appreciate you, Nora, for picking this one up—it's looking great! 🤝

LukasTy
LukasTy approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💙

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 7, 2024
@MBilalShafi MBilalShafi changed the base branch from next to master March 21, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

@danilo-leal danilo-leal danilo-leal approved these changes

@cherniavskii cherniavskii Awaiting requested review from cherniavskii

Assignees

@noraleonte noraleonte

Labels
component: data grid This is the name of the generic UI component, not the React module! design This is about UI or UX design, please involve a designer PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@noraleonte @mui-bot @LukasTy @cherniavskii @danilo-leal