[pickers] Fix DigitalClock DST related problem
#10793
Open
+108
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
bug 🐛
|
Deploy preview: https://deploy-preview-10793--material-ui-x.netlify.app/ |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
flaviendelangle
approved these changes
Nov 9, 2023
| @@ -124,6 +124,21 @@ export const mergeDateAndTime = <TDate>( | |||
| return mergedDate; | |||
| }; | |||
|
|
|||
| export const isEqualTime = <TDate>( | |||
There was a problem hiding this comment.
I am afraid this is risky if we support ms one day.
Can the ms be different? If not we could check them as well
|
@LukasTy what is the current status of this PR? |
I shelved it while tackling more pressing matters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10783
Change
DigitalClocktime options building to usestartOfYearto avoidDSTissues.