[code-infra] Fix stylelint locally #42411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
-23
to
+22
| files: ['**/*.js', '**/*.cjs', '**/*.mjs', '**/*.jsx', '**/*.ts', '**/*.tsx'], | ||
| files: ['**/*.js', '**/*.cjs', '**/*.mjs', '**/*.ts', '**/*.tsx'], |
There was a problem hiding this comment.
We don't allow .jsx files so this shouldn't be here.
Comment on lines
-11
to
-19
| 'declaration-colon-newline-after': null, | ||
| 'function-parentheses-newline-inside': null, // not compatible with prettier | ||
| 'media-feature-range-notation': null, | ||
| 'no-empty-source': null, | ||
| 'no-missing-end-of-source-newline': null, | ||
| 'selector-class-pattern': null, | ||
| 'string-no-newline': null, // not compatible with prettier | ||
| 'value-keyword-case': null, | ||
| 'value-list-comma-newline-after': null, // not compatible with prettier |
There was a problem hiding this comment.
No idea what's going on here. I'm simply trying to follow the default as much as possible, it seems to pass. I saw Base UI is doing this.
oliviertassinari
changed the title
Netlify deploy previewhttps://deploy-preview-42411--material-ui.netlify.app/ Bundle size report |
This was referenced May 26, 2024
mnajdova
approved these changes
May 27, 2024
oliviertassinari
added a commit
that referenced
this pull request
May 28, 2024
A continuation of #42411
|
Apparently, it's not very effective https://stylelint.io/user-guide/configure/#ignorefiles 
Fixed in 70327ca |
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
A continuation of mui#42411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
pnpm stylelintlocally with Next.js having already done a build, it will crash with:Annoying.
Instead, I'm reproducing the fix done in Base UI by @michaldudak https://github.com/mui/base-ui/blob/bf8fca5f2aac3d6d39d41496a20d722d67cc1fba/.stylelintrc.js#L7.
I found this testing some stuff with Pigment CSS.