Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[system][docs] Tweak the Usage demos #41242

Merged
merged 10 commits into from
Mar 4, 2024

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Feb 22, 2024

This PR adds some slight design tweaks to the MUI System usage demos. The main thing that caught my attention was that those demos weren't pulling the Box directly from the @mui/system package, which is confusing to me (not sure if that was intentional, though). This PR changes that, too. Aside from this, also added minor tweaks to the markdown.

@danilo-leal danilo-leal added docs Improvements or additions to the documentation package: system Specific to @mui/system design This is about UI or UX design, please involve a designer labels Feb 22, 2024
@danilo-leal danilo-leal self-assigned this Feb 22, 2024
@mui-bot
Copy link

mui-bot commented Feb 22, 2024

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d9f54a8

@danilo-leal
Copy link
Contributor Author

(Note: I have no idea why the test_regressions-1 is failing — would appreciate it if someone could shed some light! 😬)

Copy link

netlify bot commented Feb 26, 2024

Deploy Preview for resonant-twilight-4b0c91 ready!

Name Link
🔨 Latest commit f681390
🔍 Latest deploy log https://app.netlify.com/sites/resonant-twilight-4b0c91/deploys/65dcebe98b057a000846d7de
😎 Deploy Preview https://deploy-preview-41242--resonant-twilight-4b0c91.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danilo-leal
Copy link
Contributor Author

I'd appreciate an insight about why these tests are failing 😕

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 28, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 1, 2024
@danilo-leal
Copy link
Contributor Author

@brijeshb42 & @siriwatknp any guidance about this one? 👀

@danilo-leal danilo-leal merged commit 37bad2a into mui:master Mar 4, 2024
19 checks passed
@danilo-leal danilo-leal deleted the update-system-usage-demos branch March 4, 2024 20:39
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer docs Improvements or additions to the documentation package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants