[zero] Prepare zero-runtime packages for public release #41226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-41226--material-ui.netlify.app/ Bundle size report |
siriwatknp
reviewed
Feb 22, 2024
siriwatknp
reviewed
Feb 22, 2024
siriwatknp
reviewed
Feb 22, 2024
There was a problem hiding this comment.
@mnajdova What's your thought about 0.0.1 without the alpha? I don't think we need alpha if we follow Semver.
@brijeshb42 Have you tried pnpm publish --filter="@mui/zero-*" --tag latest --dry-run?
brijeshb42
force-pushed
the
zero-release
branch
from
476f0f9
to
f13e627
Compare
Yes. This works. I'll also test actual publishing to csb later and fix if any bugs are found. |
siriwatknp
requested changes
Feb 23, 2024
There was a problem hiding this comment.
@brijeshb42 I think after removing alpha from the version, this should be ready to merge.
brijeshb42
force-pushed
the
zero-release
branch
from
f13e627
to
c4220e8
Compare
brijeshb42
force-pushed
the
zero-release
branch
3 times, most recently
from
eaab7de
to
4a77d9d
Compare
Includes * Updated metadata in package.json * Added License banner to the output files * Copy LICENSE file to the packages * Add @emotion/styled @emotion/react as direct dep of zero-runtime, event though both aren't used anywhere, but zero-runtime depends on system which in turn requires these to be present. This will create an issue with standalone zero-runtime installation otherwise.
brijeshb42
force-pushed
the
zero-release
branch
from
4a77d9d
to
de67a7f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes