Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix pickers product name #37825

Merged
merged 1 commit into from
Jul 5, 2023
Merged

[docs] Fix pickers product name #37825

merged 1 commit into from
Jul 5, 2023

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jul 5, 2023 •
edited
Loading

The productId for pickers is used as x-date-pickers everywhere else.
It makes sense to align it here as well in order to avoid having discrepancy, between, which productId to add to the md file when. 🤷

@LukasTy LukasTy added the scope: docs-infra Specific to the docs-infra product label Jul 5, 2023
@mui-bot
Copy link

mui-bot commented Jul 5, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-37825--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 3f452a2

@LukasTy LukasTy mentioned this pull request Jul 5, 2023
Merged
@LukasTy LukasTy marked this pull request as ready for review July 5, 2023 08:50
alexfauquette
alexfauquette approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effectively it sounds more coherent

@LukasTy LukasTy merged commit 41f15df into mui:master Jul 5, 2023
18 of 19 checks passed
@LukasTy LukasTy deleted the fix-pickers-markdown-parsing branch July 5, 2023 09:03
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: date picker This is the name of the generic UI component, not the React module! regression A bug, but worse labels Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette approved these changes

@oliviertassinari oliviertassinari Awaiting requested review from oliviertassinari

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: date picker This is the name of the generic UI component, not the React module! regression A bug, but worse scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LukasTy @mui-bot @alexfauquette @oliviertassinari