Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Format number icons search #32239

Merged
merged 1 commit into from
Apr 11, 2022
Merged

[docs] Format number icons search #32239

merged 1 commit into from
Apr 11, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Apr 10, 2022 •
edited
Loading

@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation package: icons Specific to @mui/icons labels Apr 10, 2022
@mui-bot
Copy link

mui-bot commented Apr 10, 2022 •
edited
Loading

No bundle size changes

Generated by 🚫 dangerJS against 8a0a103

michaldudak
michaldudak approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliviertassinari oliviertassinari merged commit 209c3b4 into mui:master Apr 11, 2022
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Apr 11, 2022 •
edited
Loading

Browser compatibility seems OK and I can't find other instances of a new Intl.NumberFormat( usage in the codebase, so no code duplication. In MUI Store, we have https://github.com/mui/mui-store/blob/4eeb3c8113716f8e8ff2e7a936bbd41e5ef98127/web/src/modules/formatter.js#L13

@oliviertassinari oliviertassinari deleted the docs-format-number-search branch April 11, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to the documentation package: icons Specific to @mui/icons
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviertassinari @mui-bot @michaldudak