Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Flush scheduled effects before user event returns #26447

Merged
merged 3 commits into from
May 25, 2021
Merged

[test] Flush scheduled effects before user event returns #26447

merged 3 commits into from
May 25, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 25, 2021

Otherwise it wouldn't behave the same as using fireEvent.click. react@next started failing due to not flushing the scheduled effects.

@eps1lon eps1lon added the test label May 25, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented May 25, 2021 •
edited
Loading

No bundle size changes (experimental)

Generated by 🚫 dangerJS against d46485a

@github-actions github-actions bot mentioned this pull request May 25, 2021
Closed
@eps1lon eps1lon marked this pull request as ready for review May 25, 2021 11:17
@eps1lon eps1lon changed the title [test] Flush scheduled effects before user event completes [test] Flush scheduled effects before user event returns May 25, 2021
@eps1lon eps1lon merged commit bb0bbe2 into mui:next May 25, 2021
@eps1lon eps1lon deleted the test/flush-effects-in-user-events branch May 25, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eps1lon @mui-pr-bot