Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Merge options in experimentalStyled #26396

Merged
merged 7 commits into from
May 20, 2021

Conversation

mnajdova
Copy link
Member

BREAKING CHANGE

The options inside the experimentalStyled are now merged under one object.

-experimentalStyled(Button, { shouldForwardProp: (prop) => prop !== 'something' }, { skipSx: true })(...);
+experimentalStyled(Button, { shouldForwardProp: (prop) => prop !== 'something', skipSx: true })(...);

@mui-pr-bot
Copy link

mui-pr-bot commented May 20, 2021

Details of bundle changes (experimental)

@material-ui/core: parsed: -0.13% 😍, gzip: -0.01% 😍
@material-ui/lab: parsed: -0.10% 😍, gzip: -0.02% 😍

Generated by 🚫 dangerJS against d8c5940

@mnajdova mnajdova marked this pull request as ready for review May 20, 2021 18:18
@mnajdova
Copy link
Member Author

Going to merge to avoid updating on each commit. @siriwatknp please update the remaining PRs for migrating components considering this change.

Thanks for the quick review @eps1lon 🙏

@mnajdova mnajdova merged commit 6209295 into mui:next May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants