Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Migrate PickersCalendarHeader to emotion #26354

Merged
merged 7 commits into from
May 21, 2021
Merged

[pickers] Migrate PickersCalendarHeader to emotion #26354

merged 7 commits into from
May 21, 2021

Conversation

siriwatknp
Copy link
Member

@mui-pr-bot
Copy link

mui-pr-bot commented May 18, 2021 •
edited
Loading

Details of bundle changes (experimental)

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%

Generated by 🚫 dangerJS against 017265e

@github-actions github-actions bot mentioned this pull request May 18, 2021
Closed
@oliviertassinari oliviertassinari added the component: pickers This is the name of the generic UI component, not the React module! label May 18, 2021
@siriwatknp siriwatknp marked this pull request as ready for review May 19, 2021 02:28
@siriwatknp siriwatknp requested a review from mnajdova May 19, 2021 02:28
@siriwatknp siriwatknp mentioned this pull request May 19, 2021
Closed
mnajdova
mnajdova reviewed May 20, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few polishments needed

packages/material-ui-lab/src/CalendarPicker/PickersCalendarHeader.tsx Outdated Show resolved Hide resolved
packages/material-ui-lab/src/CalendarPicker/PickersCalendarHeader.tsx Outdated Show resolved Hide resolved
packages/material-ui-lab/src/CalendarPicker/PickersCalendarHeader.tsx Outdated Show resolved Hide resolved
packages/material-ui-lab/src/CalendarPicker/PickersCalendarHeader.tsx Outdated Show resolved Hide resolved
packages/material-ui-lab/src/CalendarPicker/PickersCalendarHeader.tsx Outdated Show resolved Hide resolved
@siriwatknp siriwatknp requested a review from mnajdova May 20, 2021 10:17
mnajdova
mnajdova approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See last two comments before merging.

@siriwatknp siriwatknp merged commit 12a017d into mui:next May 21, 2021
@siriwatknp siriwatknp deleted the pickers-calendar-header-emotion branch May 21, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@siriwatknp @mui-pr-bot @oliviertassinari @mnajdova