[core] Use playwright instead of puppeteer #23906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% |
eps1lon
force-pushed
the
core/drop-pptr
branch
from
28e968b
to
c131c30
Compare
eps1lon
force-pushed
the
core/drop-pptr
branch
from
c131c30
to
d13faa7
Compare
eps1lon
force-pushed
the
core/drop-pptr
branch
from
eee614a
to
d223882
Compare
eps1lon
force-pushed
the
core/drop-pptr
branch
from
d223882
to
f77f500
Compare
eps1lon
force-pushed
the
core/drop-pptr
branch
from
f77f500
to
57c30de
Compare
oliviertassinari
approved these changes
Dec 12, 2020
eps1lon
force-pushed
the
core/drop-pptr
branch
from
b7d0ee5
to
c850c8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #23944 (diff)
Now that the regression suite stabilized we can convert the remaining uses of puppeteer to have a consistent chrome binary (and access to other browsers).
Interesting that a previously flaky test is now always failing: https://app.circleci.com/pipelines/github/mui-org/material-ui/29148/workflows/250f95a5-4fe1-4145-a44c-df0b84ec2447/jobs/202853