Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rocket.Chat hive #261

Merged
merged 2 commits into from
Aug 14, 2019
Merged

Add Rocket.Chat hive #261

merged 2 commits into from
Aug 14, 2019

Conversation

dvob
Copy link
Contributor

@dvob dvob commented Aug 12, 2019

Add hive which allows to send messages into a Rocket.Chat channel.

@@ -0,0 +1,190 @@
/*
* Copyright (C) 2016 Sergio Rubio
* 2017 Christian Muehlhaeuser
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to add yourself here and a couple lines below under Authors:.

},
{
Name: "alias",
Description: "The name to show as sender. If empty the to which the user_id belongs to.",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second sentence sounds a bit broken. It probably means If empty, the name to which the user_id belongs to?

@muesli
Copy link
Owner

muesli commented Aug 13, 2019

Nice work! A few more comments:

  • client.go could almost become its own library. I'm fine with it for now, seeing how the scope is still fairly limited, but it's something one should eventually think about.

  • it would be nice to have events, too!

  • the logo seems to be cut off at the right border?

@dvob
Copy link
Contributor Author

dvob commented Aug 13, 2019

Thank you for revewing the code. I added my self as author and changed the description of the alias setting.

When I find some time, I may implement support for events as well. But right now, for me sending messages has priority.
I agree that if the Rocket.Chat API client grows it should become its own library, but for now I think its ok like that.
If I implement the event part I probably use https://github.com/detached/gorocket, but currently two things in gorocket are missing:

  • authentication with user-id and auth-token
  • get the channel ID by the channel name.

The logo looks good on me. Did you look at the logo in Github and didn't see the scrollbar under the picture?

@muesli
Copy link
Owner

muesli commented Aug 14, 2019

Hah, sorry about that, you're right about the logo! LGTM!

@muesli muesli added the hive label Aug 14, 2019
@muesli muesli merged commit 0972f05 into muesli:master Aug 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants