-
-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rocket.Chat hive #261
Add Rocket.Chat hive #261
Conversation
@@ -0,0 +1,190 @@ | |||
/* | |||
* Copyright (C) 2016 Sergio Rubio | |||
* 2017 Christian Muehlhaeuser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to add yourself here and a couple lines below under Authors:
.
}, | ||
{ | ||
Name: "alias", | ||
Description: "The name to show as sender. If empty the to which the user_id belongs to.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second sentence sounds a bit broken. It probably means If empty, the name to which the user_id belongs to
?
Nice work! A few more comments:
|
Thank you for revewing the code. I added my self as author and changed the description of the alias setting. When I find some time, I may implement support for events as well. But right now, for me sending messages has priority.
The logo looks good on me. Did you look at the logo in Github and didn't see the scrollbar under the picture? |
Hah, sorry about that, you're right about the logo! LGTM! |
Add hive which allows to send messages into a Rocket.Chat channel.