Prometheus Bee #231
Merged
Prometheus Bee #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muesli
reviewed
Apr 30, 2019
muesli
reviewed
Apr 30, 2019
muesli
reviewed
Apr 30, 2019
muesli
reviewed
Apr 30, 2019
|
Looking good! Added a few super nitpicky remarks, but nothing major stood out! Obviously still need to sort out those go.mod issues, but that's not your fault. |
|
I've fixed the httplex dependency issues in master. If you rebase and re-add the new required dependencies, we can merge this! |
muesli
reviewed
May 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A solution for issue #144 !
Might not merge immediately due to outstanding issues with the go.mod file, but it can at least be inspected :)