[Bug] Cannot build mucommander on Mac with Apple silicon

[Andreas0602]

Is there an existing issue for this?

• I have searched the existing issues (including the closed ones)

Description

I cannot build muCommander on my Mac with Apple silicon.

Steps to reproduce

In terminal.app, enter the following command:

git clone --recurse-submodules [email protected]:mucommander/mucommander.git && cd mucommander && ./gradlew dmg -Parch=aarch64

Expected behavior

mucommander.dmg will be built.

Actual behavior

mucommander.dmg will not be built.

See build.log for error message.

build.log

Screenshots?

No response

muCommander version

b3e3855

Java version

% java --version     
openjdk 21.0.2 2024-01-16
OpenJDK Runtime Environment Homebrew (build 21.0.2)
OpenJDK 64-Bit Server VM Homebrew (build 21.0.2, mixed mode, sharing)

Operating System type and version

Name: Mac OS X
Version: 14.4.1
Architecture: aarch64

Relevant log output

see build.log

[ahadas]

yeah, that's because of the work-in-progress to sign the dmg also as part of the nightly build

[Andreas0602]

@ahadas, It still doesn't work.

build.log

[ahadas]

@ahadas, It still doesn't work.

build.log

ok, so you'll need to drop two lines from the build.gradle file in order to produce an unsigned dmg

[Andreas0602]

@ahadas, It still doesn't work.

build.log

[ahadas]

@ahadas, It still doesn't work.

build.log

@Andreas0602 did you remove the last characters from the line before (comma and slash)?

[Andreas0602]

@Andreas0602 did you remove the last characters from the line before (comma and slash)?

@ahadas, No, but I did it just now, and it still doesn't work.

build.log

[ahadas]

@Andreas0602 did you remove the last characters from the line before (comma and slash)?

@ahadas, No, but I did it just now, and it still doesn't work.

build.log

it looks like you're not using the latest code since the 'dmg' task no longer signs the dmg, I believe that once you'll rebase you will be able to create an unsigned dmg locally. but why do you create a dmg locally in the first place? you can now install the dmg from the latest nightly build instead

[Andreas0602]

No, I deleted everything in my working directory and made a fresh checkout.

Yes, I have Java 21 installed on my machine. (I wrote that already in my initial bug report.)

Yes, the nightly builds are fine (by the way, you need to update the link on the mucommander home page), but I would also like to be able to build from a branch. But if it's too much work for you to support this, it's also okay. Don't worry.

[ahadas]

Yes, I have Java 21 installed on my machine. (I wrote that already in my initial bug report.)

ack, I removed my comment about that because I looked at it again and I don't see why codesign would be called at all..

Yes, the nightly builds are fine

thanks for the confirmation!

(by the way, you need to update the link on the mucommander home page)

yeah, will do

, but I would also like to be able to build from a branch. But if it's too much work for you to support this, it's also okay. Don't worry.

I'll look at it but I'm still changing that part, so once it stabilizes

[ahadas]

Yes, I have Java 21 installed on my machine. (I wrote that already in my initial bug report.)

ack, I removed my comment about that because I looked at it again and I don't see why codesign would be called at all..

ok, it reproduces on my machine with Java 21, I'm getting:

> Task :dmg FAILED
java.io.IOException: Command [/usr/bin/codesign, -s, -, -vvvv, --force, /var/folders/1j/n6gk9yxx66n6cb8ccrsz4t6c0000gn/T/jdk.jpackage2638180645781310320/images/image-8809667923087310463/muCommander.app] exited with 1 code

it is similar to what I saw few days ago - that Java missed passing the --deep argument to codesign so it fails on signing the app folder. we can use this issue for tracking this bug but it will take some time for me to get to this - in the meantime, Java 18 (or lower I suppose) is required for creating a dmg

(by the way, you need to update the link on the mucommander home page)

yeah, will do

done