Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datachannel not closing & can't connect after refresh #34

Open
manoharan250 opened this issue May 29, 2013 · 4 comments
Open

datachannel not closing & can't connect after refresh #34

manoharan250 opened this issue May 29, 2013 · 4 comments

Comments

@manoharan250
Copy link

onclose is not firing when other peer leaves the group
and can't connect to the same group on joining( no peer connection established)

@muaz-khan
Copy link
Owner

onclose is not firing when other peer leaves the group

If you meant DataChannel.js, onclose is fired each time when a user leaves the session by either closing tab/window or by clicking a LINK. However, if a user refreshes the page, previously DataChannel.js was not calling leave method. Now, it is fixed.

and can't connect to the same group on joining( no peer connection established)

If you're referencing this demo, someone as an "initiator" refreshed the page that's why socket.onDisconnect().remove() was not called. This DataChannel.js file is updated to leave channels on page refresh.

@manoharan250
Copy link
Author

Thanks for your reply,
Am testing https://webrtc-experiment.appspot.com/chat-hangout/ over socketio, not using the datachannel.js.
Referred files are
RTCPeerConnection-v1.5.js
hangout.js
hangout-ui.js

@muaz-khan
Copy link
Owner

In hangout.js file, at line 65, you should add following lines:

onChannelClosed: function (event) {
    console.error(event);
}

Because RTCPeerConnection-v1.5 is calling it here.

Next updates will fix this issue.

@manoharan250
Copy link
Author

Actually,
This channel.onclose = function (event) in RTCPeerConnection-v1.5 is not firing.
Not able to rejoin also

muaz-khan added a commit that referenced this issue May 30, 2013
https://webrtc-experiment.appspot.com/chat-hangout/
https://webrtc-experiment.appspot.com/file-hangout/

Both experiments are now firing "channel.onclose" event.

New TURN format is added for RTCMultiConnection v1.1, v1.2 and v1.3 —
DataChannel.js —  RTCall.js — and RTCPeerConnection v1.5 and v1.6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants