Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added webpack config for generating UMD enabled distribution files #664

Merged
merged 2 commits into from
Aug 26, 2020
Merged

Added webpack config for generating UMD enabled distribution files #664

merged 2 commits into from
Aug 26, 2020

Conversation

fzngagan
Copy link
Contributor

  • I put this together to generate a UMD processed distribution file.

@fzngagan fzngagan mentioned this pull request Aug 13, 2020
Open
thijstriemstra
thijstriemstra suggested changes Aug 13, 2020
View reviewed changes
dist/RecordRTC.min.js.LICENSE.txt Outdated
@@ -0,0 +1,294 @@
/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks not right, a .min.js.LICENSE.txt file 😄

@fzngagan
Copy link
Contributor Author

@thijstriemstra
Yeah, that looks silly at the first glance but it is generated a default of the TerserPlugin. I added a commit disabling extractComments which gets rid of that .LICENSE.txt file. Explained here. https://webpack.js.org/plugins/terser-webpack-plugin/#extractcomments

@muaz-khan muaz-khan merged commit 81a31af into muaz-khan:master Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thijstriemstra thijstriemstra thijstriemstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fzngagan @thijstriemstra @muaz-khan