Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebrand and fix bugs #1

Merged
merged 18 commits into from
May 7, 2024
Merged

Rebrand and fix bugs #1

merged 18 commits into from
May 7, 2024

Conversation

mttbernardini
Copy link
Owner

Taking over this project since the original is not maintained since 2022.

As I'm not planning on bringing this back to upstream, but rather deviate onto my own project, I changed all the plugin IDs and original branding/credits. This is a breaking change, so versioning of this project will start from 2.0.0, as it's forked from upstream at version 1.1.0.

Fixes:

  • Quality factor should have 0.01 increments, and the label should display 2 decimal places.
  • All bands should be off by default, so filters can be activated as needed, ideally reducing computing demand.

Other Changes:

  • Don't build AAX and VST2. I only care about VST3 and AU for now.
  • Updated JUCE 6.1.2 -> 7.0.12
  • Deleted original branding, replaced with my own minimal credits (plugin version and my website).

TODOs:

  • Setup GitHub pipeline to automatically build on tags and attach built artifacts (delete the old workflow). Not planning on providing installers, just the vst3 files so they're easier to copy around (and possibly provide a single combined windows-macOS universal binary).
  • Have a look at upstream issues and check if there's anything relevant to fix.

@mttbernardini mttbernardini self-assigned this May 7, 2024
@mttbernardini mttbernardini added the enhancement New feature or request label May 7, 2024
@mttbernardini mttbernardini merged commit 5d9be60 into master May 7, 2024
@mttbernardini mttbernardini deleted the feat/modernize branch May 7, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant