Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Faker references in README #216

Merged
merged 1 commit into from
May 19, 2022
Merged

Conversation

shawntax
Copy link
Contributor

@shawntax shawntax commented May 19, 2022

Hello!

In January 2022 there was an incident with the original maintainer of faker.js, and there is a new community-maintained library for it -- more context on all that here.

This PR updates references to Faker in the readme to point to the new GitHub repository, and for code samples to use the updated @faker-js/faker dependency.

Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @shawntax! 🎉 Welcome to contributors.

@kettanaito kettanaito merged commit 6796f34 into mswjs:main May 19, 2022
@kettanaito
Copy link
Member

Please, would you be interested in updating the faker as a dependency in the library? I think we're using it for internal testing.

@shawntax shawntax deleted the patch-1 branch May 20, 2022 00:04
@shawntax
Copy link
Contributor Author

@kettanaito Happy to give it a go! I've created #217, feel free to assign to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants