Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix obs.mat feature of fitcn #71

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix obs.mat feature of fitcn #71

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebc169a
fix constrain.observations. In addition to some other small changes.
ShaiberAlon Dec 10, 2021
0e30ab8
added a test for fit.cn
ShaiberAlon Dec 13, 2021
75ecbcc
cosmetic
ShaiberAlon Dec 13, 2021
b5d4dc6
added comment
ShaiberAlon Dec 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Prev Previous commit
Next Next commit
added a test for fit.cn
  • Loading branch information
@ShaiberAlon
ShaiberAlon committed Dec 13, 2021
commit 0e30ab8d2fcf569a8ce965f9993f4a14e3c0ff8a
4 changes: 2 additions & 2 deletions tests/testthat/test_gGnome_ops.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ test_that('fitcn, simple/TRA', { # we include the test for TRA here since h526 h
sol = gGnome::fitcn(wks, return.gw = FALSE)

# TODO: not adding a test for obs.mat for now since it is failing.
# obs.mat = matrix(1, nrow = length(wks), ncol = length(wks))
#res = gGnome::fitcn(wks, obs.mat = obs.mat, verbose = TRUE)
obs.mat = matrix(1, nrow = length(wks), ncol = length(wks))
res = gGnome::fitcn(wks, obs.mat = obs.mat, verbose = TRUE)

foo = refresh(wks2)$fitcn(verbose = TRUE)
foo = refresh(wks2)$fitcn(verbose = TRUE, edgeonly = TRUE)
Expand Down