Adding the possibility to auto refresh the sticky comment position... #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vincent-joignie-dd Thanks for the PR. Very interesting idea. Will review and report back. |
|
Any news @mshick ? |
|
I would really like this idea, or hiding the previous comments if non-sticky |
|
Hey there, sorry for the delay. IRL I just moved, had holidays, etc... Hate to leave you hanging. I'm getting this properly tested now — as you see, the forked PR perms make this difficult to test in practice. Will report back today. |
|
Okay! Finally tested and it's looking good. More comments TK. |
mshick
requested changes
Jan 6, 2023
+ now defaulting new option to "false"
|
@mshick Changes have been applied. ;) |
mshick
approved these changes
Apr 14, 2023
|
@all-contributors please add @vincent-joignie-dd for code |
|
I've put up a pull request to add @vincent-joignie-dd! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to be the last comment in the thread!