Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds info about required pull-requests permission #48

Merged
merged 8 commits into from
Nov 5, 2022

Conversation

jritsema
Copy link
Contributor

@jritsema jritsema commented Sep 1, 2022

I needed to add the pull-requests: true permission in order to get this to work.

@mshick
Copy link
Owner

mshick commented Nov 4, 2022

Sorry for the delay, I'll look to incorporate. Thanks for the PR!

Copy link
Owner

@mshick mshick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@mshick
Copy link
Owner

mshick commented Nov 5, 2022

@jritsema I added the permissions to the workflow on master and merged in, but Dogfood is still failing. Does it look like I did that right?

@mshick mshick added the documentation Improvements or additions to documentation label Nov 5, 2022
@mshick
Copy link
Owner

mshick commented Nov 5, 2022

Trying to figure out permissions. It just seems like they are for using more granular permissions on your jobs. Adding to the docs makes sense so that people know what is required. I think the perms required are actually these:

    permissions:
      issues: write
      pull-requests: read

Can you update the PR with those if that makes sense?

@mshick
Copy link
Owner

mshick commented Nov 5, 2022

Working with it a bit more, I see pull-requests: write is definitely required and issues is not. Very weird, since the methods used are all issues scoped.

@mshick mshick merged commit bd2c7fd into mshick:master Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants