Skip to content
This repository has been archived by the owner on Jan 3, 2020. It is now read-only.

Initial checkin for the Node.js UWP code #1

Merged
merged 12 commits into from
May 22, 2015
Prev Previous commit
Next Next commit
Minor update to readme
  • Loading branch information
Munyiri Kamau committed May 14, 2015
commit fb0d466660c2fe487e05c320d8a2e4522cccbbda
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ Prerequisites:

Steps:

* Set node_dir in build.bat to your Node.js clone
* Set node_dir in build.bat to the path of your Node.js clone
* Set release_dir if desired (optional)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editing these in build.bat? Why not set them in the environment?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just thought it would be better/easier because it can just be done once and there would be no need to set them in the environment (either every time before running build.bat or once through windows environment settings). I'll leave it for now but let me know if you feel strongly about this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually maybe to be consistent with vcbuild.bat I should change this. will fix.

* `build.bat [x86|x64|arm] [copyrelease]`
* build.bat [x86|x64|arm] [copyrelease]