Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate word #82

Merged
merged 1 commit into from
Sep 12, 2017
Merged

Remove duplicate word #82

merged 1 commit into from
Sep 12, 2017

Conversation

sapegin
Copy link
Contributor

@sapegin sapegin commented Sep 12, 2017

No description provided.

@mrsteele
Copy link
Owner

Haha, hilarious / embarrassing! I'm not an English major 🤣

@mrsteele
Copy link
Owner

thanks @sapegin

@mrsteele mrsteele merged commit c9edea0 into mrsteele:master Sep 12, 2017
@sapegin sapegin deleted the patch-1 branch September 12, 2017 13:29
@sapegin
Copy link
Contributor Author

sapegin commented Sep 12, 2017

@mrsteele Actually I’m a bit unsure about this sentence ;-) What exactly “overwrites any existing DefinePlugin” means? Does it mean that this plugin can’t be used with DefinePlugin?

@mrsteele
Copy link
Owner

@sapegin So it used to be the case that this plugin was not compatible with DefinePlugin. It appears at some point it became compatible. So that sentence might be void at this point.

@sapegin
Copy link
Contributor Author

sapegin commented Sep 12, 2017

I don’t see anything that suggest that you can’t use DefinePlugin multiple times in their docs except:

When defining values for process prefer 'process.env.NODE_ENV': JSON.stringify('production') over process: { env: { NODE_ENV: JSON.stringify('production') } }. Using the latter will overwrite the process object which can break compatibility with some modules that expect other values on the process object to be defined.

@mrsteele
Copy link
Owner

mrsteele commented Sep 12, 2017

Yeah we are probably good to remove that DefinePlugin bit 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants