New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat each entry as a seperate JSON string #35

Merged

mrsteele merged 2 commits into mrsteele:master from piersroberts:master

Feb 9, 2017

Contributor

piersroberts commented Feb 9, 2017

Should fix #34


Treat each entry as a seperate JSON string

e1fb62a

Should fix mrsteele#34

Owner

mrsteele commented Feb 9, 2017

Tests are failing. Run npm t locally to check it out. Tests might need updating after this update.

Owner

mrsteele commented Feb 9, 2017

You need to remove JSON.parse from envTest since it is parsed sooner:

  function envTest (config) {
    return new Obj(config).definitions['process.env']
  }

.. as well as wrap the test values:

const envEmptyJson = {}
const envSimpleJson = {TEST: JSON.stringify('testing')}
const envMissingOneJson = {TEST: JSON.stringify(''), TEST2: JSON.stringify('Hello')}


ci: Fixed test to pass with quoted JSON style quoted vars

715c080

Contributor Author

piersroberts commented Feb 9, 2017

Cool :) took longer to work out your commit message syntax than fix the tests! :D

coveralls commented Feb 9, 2017

Coverage remained the same at 100.0% when pulling 715c080 on piersroberts:master into a183221 on mrsteele:master.

4 similar comments

coveralls commented Feb 9, 2017

Coverage remained the same at 100.0% when pulling 715c080 on piersroberts:master into a183221 on mrsteele:master.

coveralls commented Feb 9, 2017

Coverage remained the same at 100.0% when pulling 715c080 on piersroberts:master into a183221 on mrsteele:master.

coveralls commented Feb 9, 2017

Coverage remained the same at 100.0% when pulling 715c080 on piersroberts:master into a183221 on mrsteele:master.

coveralls commented Feb 9, 2017

Coverage remained the same at 100.0% when pulling 715c080 on piersroberts:master into a183221 on mrsteele:master.

mrsteele merged commit 17fae87 into mrsteele:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment