perf: Mark error paths as [[unlikely]] (#19)

mrousavy · Jan 19, 2024 · bbbdff2 · bbbdff2
1 parent 0313eec
commit bbbdff2
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/cpp/TensorHelpers.cpp b/cpp/TensorHelpers.cpp
@@ -85,6 +85,7 @@ size_t TensorHelpers::getTFLTensorDataTypeSize(TfLiteType dataType) {
  case kTfLiteUInt16:
  return sizeof(uint16_t);
  default:
+ [[unlikely]];
  throw std::runtime_error("Unsupported output data type! " + dataTypeToString(dataType));
  }
 }
@@ -125,8 +126,8 @@ TypedArrayBase TensorHelpers::createJSBufferForTensor(jsi::Runtime& runtime,
  return TypedArray<TypedArrayKind::Uint16Array>(runtime, size);
  case kTfLiteUInt32:
  return TypedArray<TypedArrayKind::Uint32Array>(runtime, size);
-
  default:
+ [[unlikely]];
  throw std::runtime_error("Unsupported tensor data type! " + dataTypeToString(dataType));
  }
 }
@@ -138,6 +139,7 @@ void TensorHelpers::updateJSBufferFromTensor(jsi::Runtime& runtime, TypedArrayBa
 
  void* data = TfLiteTensorData(tensor);
  if (data == nullptr) {
+ [[unlikely]];
  throw std::runtime_error("Failed to get data from tensor \"" + name + "\"!");
  }
 
@@ -185,8 +187,8 @@ void TensorHelpers::updateJSBufferFromTensor(jsi::Runtime& runtime, TypedArrayBa
  .as<TypedArrayKind::Uint32Array>(runtime)
  .updateUnsafe(runtime, (uint32_t*)data, size);
  break;
-
  default:
+ [[unlikely]];
  throw jsi::JSError(runtime, "Unsupported output data type! " + dataTypeToString(dataType));
  }
 }
@@ -195,11 +197,12 @@ void TensorHelpers::updateTensorFromJSBuffer(jsi::Runtime& runtime, TfLiteTensor
  TypedArrayBase& jsBuffer) {
  auto name = std::string(TfLiteTensorName(tensor));
  auto buffer = jsBuffer.getBuffer(runtime);
- 
+
 #if DEBUG
  int inputBufferSize = buffer.size(runtime);
  int tensorSize = getTensorTotalLength(tensor) * getTFLTensorDataTypeSize(tensor->type);
  if (tensorSize != inputBufferSize) {
+ [[unlikely]];
  throw std::runtime_error("Input Buffer size (" + std::to_string(inputBufferSize) + ") does not "
  "match the Input Tensor's expected size (" + std::to_string(tensorSize) + ")! "
  "Make sure to resize the input values accordingly.");

diff --git a/cpp/TensorflowPlugin.cpp b/cpp/TensorflowPlugin.cpp
@@ -140,6 +140,7 @@ TensorflowPlugin::TensorflowPlugin(TfLiteInterpreter* interpreter, Buffer model,
  // Allocate memory for the model's input/output `TFLTensor`s.
  TfLiteStatus status = TfLiteInterpreterAllocateTensors(_interpreter);
  if (status != kTfLiteOk) {
+ [[unlikely]];
  throw std::runtime_error("Failed to allocate memory for input/output tensors! Status: " +
  std::to_string(status));
  }
@@ -174,6 +175,7 @@ void TensorflowPlugin::copyInputBuffers(jsi::Runtime& runtime, jsi::Object input
  auto array = inputValues.asArray(runtime);
  size_t count = array.size(runtime);
  if (count != TfLiteInterpreterGetInputTensorCount(_interpreter)) {
+ [[unlikely]];
  throw std::runtime_error(
  "TFLite: Input Values have different size than there are input tensors!");
  }
@@ -203,6 +205,7 @@ void TensorflowPlugin::run() {
  // Run Model
  TfLiteStatus status = TfLiteInterpreterInvoke(_interpreter);
  if (status != kTfLiteOk) {
+ [[unlikely]];
  throw std::runtime_error("Failed to run TFLite Model! Status: " + std::to_string(status));
  }
 }
@@ -254,6 +257,7 @@ jsi::Value TensorflowPlugin::get(jsi::Runtime& runtime, const jsi::PropNameID& p
  for (size_t i = 0; i < size; i++) {
  TfLiteTensor* tensor = TfLiteInterpreterGetInputTensor(_interpreter, i);
  if (tensor == nullptr) {
+ [[unlikely]];
  throw jsi::JSError(runtime, "Failed to get input tensor " + std::to_string(i) + "!");
  }
 
@@ -267,6 +271,7 @@ jsi::Value TensorflowPlugin::get(jsi::Runtime& runtime, const jsi::PropNameID& p
  for (size_t i = 0; i < size; i++) {
  const TfLiteTensor* tensor = TfLiteInterpreterGetOutputTensor(_interpreter, i);
  if (tensor == nullptr) {
+ [[unlikely]];
  throw jsi::JSError(runtime, "Failed to get output tensor " + std::to_string(i) + "!");
  }