Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All libs internal, and easier to add external libs and modules #31

Closed
wants to merge 3 commits into from

Conversation

Mar2zz
Copy link
Contributor

@Mar2zz Mar2zz commented Jan 2, 2012

Independent installer.
Also:
Write a new plugin, save it in modules-dir, and it will be imported automagic in Maraschino.py.
Need a new lib, throw it in lib, and it will work and can be imported by calling it directly (import cherrypy for example).

I renamed maraschino.py to Maraschino.py so all your 'self written lib-files like modules, models etc could be inside a subdir called maraschino. I had to do this, or maraschino get confused with importing the modules.py file or the modules directory. those libs need to be imported like: from maraschino.file import function.

this is also the reason I changed maraschino.py to Maraschino.py, or else modules get confused about importing maraschino.py or the subdir maraschino.

This renaming of Maraschino.py needs to be reflected in setupinstructions.

@mrkipling
Copy link
Owner

Just had a quick look and all of the /xhr views are returning 404 for me.

@Mar2zz
Copy link
Contributor Author

Mar2zz commented Jan 2, 2012

fixed I think. mixed up the old modules.py file with the new modules directory and deleted import modules.

@mrkipling
Copy link
Owner

Still 404'ing for me...

@Mar2zz
Copy link
Contributor Author

Mar2zz commented Jan 2, 2012

not fixed. modules stay blank. wait a mmt sorry.

@mrkipling
Copy link
Owner

Oh, I think I see the problem - in your pull request you've just added new files, you should have used "git mv" when moving files.

@mrkipling
Copy link
Owner

(because the old files are still there, which is most likely messing things up)

@Mar2zz
Copy link
Contributor Author

Mar2zz commented Jan 2, 2012

fixed for me.
too bad, I thought it could import all functions/variables from all files inside modules automagic, so you would never have to update Maraschino.py if a new module is created. A new module can now be added by dropping it in modules and import it with from modules.modulename import function/variable/*.

@mrkipling
Copy link
Owner

The problem with creating brand new files inside the modules directory and deleting the old files is that we lose the history for them in git, so we can't go back in time and see who changed/added what, and when. Explicitly moving the files is the way to go with this one.

@Mar2zz
Copy link
Contributor Author

Mar2zz commented Jan 2, 2012

Op 02-01-12 21:16, Bradley Abrahams schreef:

The problem with creating brand new files inside the modules directory and deleting the old files is that we lose the history for them in git, so we can't go back in time and see who changed/added what, and when. Explicitly moving the files is the way to go with this one.


Reply to this email directly or view it on GitHub:
#31 (comment)
Ok, close it, will do it again. thank god there is sed streaming editor :)

@mrkipling
Copy link
Owner

Okey doke, thanks :)

@mrkipling mrkipling closed this Jan 2, 2012
@Mar2zz
Copy link
Contributor Author

Mar2zz commented Jan 2, 2012

Here it is :)
#32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants