Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipcamera #298

Merged
merged 6 commits into from
Jun 2, 2013
Merged

Ipcamera #298

merged 6 commits into from
Jun 2, 2013

Conversation

Hellowlol
Copy link

Ipcamera module. It only support foscam mjeg camera atm but its easy to add more cameras

@Hellowlol
Copy link
Author

webcamzz.zapto.org

u: xbmc
p: xmbc

@gugahoi
Copy link
Collaborator

gugahoi commented May 24, 2013

That is pretty cool!

@Hellowlol
Copy link
Author

I think so aswell :P I just wish i was better at css so i could make the directional buttons more like a remote.

@Hellowlol
Copy link
Author

What do i need to do to get this merged?

@N3MIS15
Copy link
Collaborator

N3MIS15 commented May 29, 2013

@gugahoi I assume you had a look? If your happy I have no objections. Otherwise I can try to review over the next couple days.

@bruvv
Copy link

bruvv commented May 30, 2013

I would like this to get merged :)

Really usefull!

'type': 'select',
'options': [
{'value':'foscammjeg', 'label':'Foscam MJEG'},
{'value':'test', 'label':'TEST'},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove test

@gugahoi
Copy link
Collaborator

gugahoi commented May 30, 2013

Ok, i am cleaning up the code. Should take some time so maybe we can have something after the weekend.

@Hellowlol
Copy link
Author

Thats great. I was looking over the code now and its awefull.. some tags that isnt needed, some isnt closed etc. There is also some mistakes in the python code for mp4 template, ill fix that and leave the rest to somebody (read: gugahoi) that knows what they are doing.

@gugahoi
Copy link
Collaborator

gugahoi commented May 31, 2013

I have already done quite a lot so if you dont mind let me finish my corrections and then we look into fixing other things...

@Hellowlol
Copy link
Author

Alright. If you want to test what you have so far you can use same url, username and pwd. Just set the port to 8986. to access the camera directly

@gugahoi gugahoi merged commit 38ed351 into mrkipling:master Jun 2, 2013
@gugahoi
Copy link
Collaborator

gugahoi commented Jun 2, 2013

Just pushed the module. Please test it out and we can iron out any remaining bugs...

@gugahoi
Copy link
Collaborator

gugahoi commented Jun 2, 2013

screen shot 2013-06-03 at 3 51 58 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants