XBMC Handler and Frodo fixes #210
Conversation
|
I'm more than happy for jsonrpclib to be replaced... my opinion about it isn't that strong right now :) You're probably more in the loop than me right now regarding Maraschino's current codebase, so feel free to merge this in if you're happy with it. It all sounds very useful. |
|
I will need to fix some conficts after the recently added merge. Once that is done If someone could at least run the changes and make sure everything XBMC seems to work for them I would be happy to merge it in. |
|
I'd be happy to pull the changes and test it out once conflicts are |
|
ok, ready for review. Ive fixed conficts and rebased. |
…and version checking Also added some fixes for frodo
|
I pulled this PR and ran it as-is, with Marachino pointing at my main Eden install. A few things were broken. This was printed to the console: https://gist.github.com/42bb2c526061edd1a20c ...which I assume is related to either the broken "currently playing" thumbnail, or the lack of fanart background image (the currently playing bar itself seemed to be working fine though). The "recently added" modules also weren't working; they were falling back to the information in the database. Let me if you need any more information. |
|
Yea it looks like a problem with the image. Can you try library info view to see if the same thing happens there. |
|
Yep, broken images in the library info view too. |
|
Some googling leads me to think that the error is on your end. Possibly a dns error? Its working fine for me with eden and frodo. |
|
Hmmm... not sure what it could be, as master is working fine for me. I'll look into it. |
… xbmc_stuff Conflicts: mobile.py
|
Had another play around with this PR at the weekend and couldn't get it to work with my main Eden install. Would love to merge it in, but I suspect that I wouldn't be the only person that Maraschino breaks for... |
|
This is odd, cause it worked for me on Eden without a hitch. |
|
is it only the images that are playing up mrkipling? |
|
Also the "recently added" modules - they' can't connect to XBMC, so they're falling back to the cached content. |
|
ok i will split this into seperate pull requests. i will start with moving all xbmc stuff to xbmc.py then look into the version checking stuff. should make for an easier review. |
I know you weren't too keen on replacing jsonrpclib for XBMC, but i think its the best way to have better and more universal/consistent error handling. There are many advantages and no disadvantages that i have found as of yet.
Anyways here are the changes:
Moved all the XBMC related tools to /maraschino/xbmc.py
Creates XBMC instance on boot and server change so there is no more setting the server every time we need to make a call to XBMC. The instance is now maraschino.XBMC.
Get XBMC version on the first successful call to XBMC
Added the ability to include dev=True in the method params, this will output the method, request params and response to console.
Added logging built into the XBMC class that will return much more useful debug logs.
The legacy server settings check is only done on program start, not page load.
Added XBMC version checking via maraschino.XBMC_VERSION
Added fixes for frodo (only triggered if maraschino.XBMC_VERSION is > 11)
questions/criticisms welcome as always :)