Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XBMC Media Manager (Frodo only) #194

Merged
merged 1 commit into from
May 11, 2014
Merged

Conversation

N3MIS15
Copy link
Collaborator

@N3MIS15 N3MIS15 commented Aug 12, 2012

This is my attempt at a media manager for the XBMC database. It uses the new json methods in XBMC to change the database entries.

Some features of the 'manager' are:
editing of movie, tv and episode information and images (music will be added at a later date)
accessing information from TMDB, TVDB and fanart.tv to get new or up to date information and or images.
exporting the library using XBMC's built in database exporter.

A picture is worth a thousand words, so here is a less than average quality video of it in action
http:https://www.youtube.com/watch?v=EhGGOI5DzFc

There is still a bit of error handling and logging to be added, but it "should" be fully functional and ready for testing to iron out any bugs that may be in there.

The UI side of things could do with a little work too, that stuff is my achilles heel..

I havent done any testing on any unix systems yet. I wanted to get this together as a PR so it can undergo some testing on other systems.

It requires a frodo build from 8th August onwards

EDIT: forgot to mention that all images get cached in the datadir/cache folder to help with the load on tvdb/tmdb/fanart.tv

@m-wichmann
Copy link
Contributor

Looks really great. Aside from the logging and input/error handling that you mentioned, I could'nt find any bugs or so.

Just a thought: Is there a way to use the scrapers of XBMC? That way only one codebase would have to be maintained.

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Aug 12, 2012

IIRC there are plans to expose the xbmc scrapers to the json api, but afaik that has not happened yet.

@mrkipling
Copy link
Owner

I'll take a look at this at the weekend, all being well. I'll probably end up installing a nightly build on a different PC, as I don't really want to use the nightlies on all of my main HTPCs that are actually in use, and there don't appear to be any monthlies for Linux-based OSes.

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Aug 15, 2012

I'm using the nightly windows builds with only a few movies and tvshows for testing..
This PR was not intended to be pulled in strait away, its more for testing. I am still working on bits and pieces to clean and stabilize things more

@mrkipling
Copy link
Owner

Gotcha... I was under the impression that you were ready for it be merged in. Keep me updated!

@m-wichmann
Copy link
Contributor

I tested this on a Ubuntu 12.04 with a recent self-compiled build of xbmc and it all worked fine.

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Aug 17, 2012

For the sake of the 'initial release' i believe this is now complete and hopefully free of bugs.

EDIT: Just for the record, this was never meant to replace things like EMM. They are file based media managers, this is a essentially a database manager for quick and easy changes.

@gugahoi
Copy link
Collaborator

gugahoi commented Aug 24, 2012

This is an awesome feature! I really wish I had time to help develop this but for the moment I will just have to follow the change...

@abrenoch
Copy link

I love this, would it be possible to see this appear as a standard xbmc add-on like xwmm?

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Sep 11, 2012

If the webserver addons support python then yea its possible it could be transfered into an XBMC addon.. If not, the code would need to be re-written in jquery or something else supported.

XWMM is where i got the idea for this.

@titan04
Copy link
Contributor

titan04 commented Oct 25, 2012

When is this going to be merged into master? Curious to try it out in Synology package update.

@bazza88
Copy link

bazza88 commented Oct 25, 2012

This looks great! Do you have any idea when it will be merged into the master source?

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Oct 27, 2012

master has changed quite a bit since this PR was first sent, there are also other things i would like in place before this gets merged.
So it may take a little while

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Dec 5, 2012

@gugahoi @mrkipling I think this should wait until Frodo is final. It's already not compatable with the betas and i would hate to see any future changes effect users databases in a bad way. When Frodo master hits i will make sure this gets updated and safe for users.

@mrkipling
Copy link
Owner

+1 to waiting until Frodo is final and the API is locked down properly. We should probably keep this branch up-to-date with master though.

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Dec 10, 2012

Updated to master.
Movies section has had a lot of work done to the templating (macros and such to make things neater). The movies section should now be 100% operational with XBMC 12 beta3.

I also decided to add support for discart, banner, clearart and clearlogo since they can be added to the XBMC database now. I used artwork downloader addon to get them initially and XBMCMM to change the 1s I didn't like :)

http:https://i47.tinypic.com/rc3lp1.png

TV shows section to come next (Its currently broken)
Music after that (currently unfinished)

@gugahoi @mrkipling @DejaVu If you think there needs to be any styling changes (from that screenshot) let me know before i go to far with modifying the rest of the templates.

@mrkipling
Copy link
Owner

@N3MIS15 Based on that screenshot I would say no styling changes necessary - looks fantastic!

Can't wait to start using this. I was looking for a web-based XBMC library editor at the weekend... think I'll just wait for Frodo and this PR :)

@jesterod
Copy link

how would i get this into my maraschino install? i dont know git hub at all i downloaded the zip in code and copied it in to the folder on my htpc where maraschino is installed but it didnt change anything after a reboot

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Dec 18, 2012

This is the zip you need: https://github.com/N3MIS15/maraschino/archive/XBMCMM.zip
If you find any bugs let me know :)

I had to disable the music section for now as there is a bug in XBMC code where any changes made to the database get overwritten whenever the music library gets scanned, see http:https://forum.xbmc.org/showthread.php?tid=68263&pid=1267736#pid1267736

I believe this is now ready for review.

@jesterod
Copy link

ok i will give it a try do i just unzip and place in the same place as
the normal maraschino and the music thing i dont use anyway lol

On 12/18/2012 1:01 AM, David Gray wrote:

This is the zip you need:
https://github.com/N3MIS15/maraschino/archive/XBMCMM.zip
If you find any bugs let me know :)

I had to disable the music section for now as there is a bug in XBMC
code where any changes made to the database get overwritten whenever
the music library gets scanned, see
http:https://forum.xbmc.org/showthread.php?tid=68263&pid=1267736#pid1267736

I believe this is now ready for review.


Reply to this email directly or view it on GitHub
#194 (comment).

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Dec 18, 2012

If you overwrite your current install make sure you do not use the built in updater, it will return Maraschino to the master version.

Please remember this is awaiting review, consider it unstable.

@jesterod
Copy link

ok no updating

On 12/18/2012 1:09 AM, David Gray wrote:

If you overwrite your current install make sure you do not use the
built in updater, it will return Maraschino to the master version.

Please remember this is awaiting review, consider it unstable.


Reply to this email directly or view it on GitHub
#194 (comment).

@jesterod
Copy link

it loads and shows the database but when i try to make changes and
click apply changes i get an error "there was and problem connecting to
the xbmc server"

On 12/18/2012 1:09 AM, David Gray wrote:

If you overwrite your current install make sure you do not use the
built in updater, it will return Maraschino to the master version.

Please remember this is awaiting review, consider it unstable.


Reply to this email directly or view it on GitHub
#194 (comment).

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Dec 18, 2012

what exactly are you trying to change? and is anything displayed in the logs?

@jesterod
Copy link

i was trying to change the movie "king of kung fu" using the tmdb lookup
that changed it to the forbidden kingdom i dont know where the logs are
im useing openelec 2.95.5 on a raspberry pi rev2 512mb
On 12/18/2012 1:40 AM, David Gray wrote:

what exactly are you trying to change? and is anything displayed in
the logs?


Reply to this email directly or view it on GitHub
#194 (comment).

@daveyy
Copy link

daveyy commented Jan 1, 2013

I have a request of how to install the openelec xbmc ? This is a special version of linux xbmc.

@jesterod
Copy link

jesterod commented Jan 1, 2013

it depends on your system http:https://openelec.tv/get-openelec theres alot of
versions

@daveyy
Copy link

daveyy commented Jan 8, 2013

OpenELEC 3.0 (RC 1) - 2.99.1 - i386 (162 MB) MD5

@BetaQuasi
Copy link

Hi,

Just wanted to firstly say great work - this is a fantastic little application, and I've been looking for a web-based XBMC db manager for Frodo for some time now!

I have one suggestion and one possible bug:

  • When adding movies to sets from the 'Movie Sets' page, would it be possible not to have the list scroll back to the top? Can make adding multiple movies a bit painful.
  • When trying to change the sort title, tag line or anything like that of a particular movie, I am getting the error 'There was a problem connecting to the XBMC server' after clicking Apply Changes. There is no issue with displaying all the metadata/images etc that are already present, just with applying changes it seems.

Thanks!

BQ

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Jan 11, 2013

@BetaQuasi, Agree with movie sets lists, the way it is now is just the easy way :).
I will need to look into why the errors are happening when i get a bit of time.

@BetaQuasi
Copy link

No worries, cheers - in fact it appears the only thing I can do at the moment is add movies to sets and change tv series metadata. Any other database writes are failing.. this is with latest Frodo RC, MyMovies75 database. I have tried:

  • renaming sets (though creating a new one is fine)
  • changing any values of a movie and applying said change (changing metadata for a tv series works 100% fine)

I installed this from the archive linked in your post above, i.e: https://github.com/N3MIS15/maraschino/archive/XBMCMM.zip, as a git pull on /N3MES15/maraschino.git seemed to just pull regular maraschino minus your work. Hope that's the right way to do things.

Hope that helps, and again, great work so far! :)

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Jan 11, 2013

Since my last tests runtime has been changed to an integer rather than string, so a simple fix and hopefully movies should be editable now.

If there are any further issues please enable debug logging in xbmc which will catch why the request fails.

@BetaQuasi
Copy link

No problem, I'll add debug logs next time :)

@Hellowlol
Copy link

Any eta on this one? I'm really looking forward to this addition.

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Feb 16, 2013

Awaiting review. I know @gugahoi was working on some ui improvments for it, but I am not sure where thats at.

@gugahoi
Copy link
Collaborator

gugahoi commented Feb 19, 2013

@N3MIS15 N3MIS15#11

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Apr 26, 2013

OK, been a while but i think this baby might finally be ready to pull in. @gugahoi what u think?

@gugahoi
Copy link
Collaborator

gugahoi commented Apr 27, 2013

I'll have a look soon, have been extremely busy lately which is why I havent really been around much but from what I remember things were looking good.

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented Jun 10, 2013

@gugahoi I think this is ready to go in. Are you able just to give it a once over.

@gugahoi
Copy link
Collaborator

gugahoi commented Jun 14, 2013

Hopefully after my exams on the 25th ill have some time...

@SlackMaster
Copy link

Hello,

I'd really like to be able to edit XBMC database from within Maraschino, can this be pulled into master?

@titan04
Copy link
Contributor

titan04 commented Feb 27, 2014

+1

On Wed, Feb 26, 2014 at 12:56 PM, SlackMaster [email protected]:

Hello,

I'd really like to be able to edit XBMC database from within Maraschino,
can this be pulled into master?

Reply to this email directly or view it on GitHubhttps://github.com//pull/194#issuecomment-36155107
.

mrkipling added a commit that referenced this pull request May 11, 2014
XBMC Media Manager (Frodo only)
@mrkipling mrkipling merged commit 3220d30 into mrkipling:master May 11, 2014
@mrkipling
Copy link
Owner

This... is so awesome! Seems to work just fine for me so I've merged it in. Good work, @N3MIS15!

@mrkipling
Copy link
Owner

Suggestion though - how about we change "XBMCMM" in the dropdown menu to something more descriptive, like "Library editor" or "Library manager"?

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented May 11, 2014

Go for it. Glad you like it.

@mrkipling
Copy link
Owner

Hmmm... editing data works great, but I can't seem to remove anything from the library, the XHR is 404ing. I'll look into it.

@mrkipling
Copy link
Owner

It looks like the URL "/xhr/library_remove/" doesn't exist. Is the URL incorrect, or has removing stuff from the library not been implemented?

Either way, loving this. Sorry it took so long to get merged in.

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented May 11, 2014

looks like it should be /xhr/xbmcmm/remove/
https://github.com/mrkipling/maraschino/pull/194/files#diff-7a0d18970d8b59ba72bc2b1eb01062bbR239
its been a long time since i looked at this code

@mrkipling
Copy link
Owner

That's what I thought when searching the codebase, but that's just the view
that returns the modal confirmation box ("Remove episode?")

On 11 May 2014 12:11, David Gray [email protected] wrote:

looks like it should be /xhr/xbmcmm/remove/

https://github.com/mrkipling/maraschino/pull/194/files#diff-7a0d18970d8b59ba72bc2b1eb01062bbR239
its been a long time since i looked at this code


Reply to this email directly or view it on GitHubhttps://github.com//pull/194#issuecomment-42767885
.

@N3MIS15
Copy link
Collaborator Author

N3MIS15 commented May 11, 2014

ok looks like i missed this when rebasing the code. luckily i kept an old copy of the branch.
https://gist.github.com/N3MIS15/e0a46acece0b29ea5abf
that belongs in modules/controls.py
i dont have time for a PR at the moment. sorry.

@mrkipling
Copy link
Owner

Fantastic, that works a treat. I've added it back in and pushed.

This is going to make clearing the crap out of my library so much easier!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet