Couchpotato Module #169
Couchpotato Module #169
Conversation
Conflicts: static/js/index.js
Conflicts: .gitignore AUTHORS Maraschino.py maraschino/modules.py maraschino/tools.py modules/applications.py modules/controls.py modules/currently_playing.py modules/library.py modules/recently_added.py modules/recommendations.py modules/sabnzbd.py modules/sickbeard.py modules/transmission.py static/js/index.js static/less/module-currently_playing.less static/less/module-library.less static/less/module-recently_added.less static/less/module-sabnzbd.less static/less/module-sickbeard.less static/less/module-transmission.less static/less/settings.less static/less/site.less templates/base.html templates/currently_playing.html templates/library.html templates/recently_added.html templates/recently_added_albums.html templates/recently_added_movies.html templates/sabnzbd-base.html templates/sabnzbd-queue.html templates/server_settings_dialog.html
A lot of API calls exposed
No more annoying expansion of results
|
Just realised I didnt proxy the images. Will have to do that before the merge. |
|
It looks to me like the images are pulled from the web, at least mine are. So it wouldnt be a game changer if they weren't proxied. |
Use Player.GoTo rather than Player.Open for playlists
|
@gugahoi
Thanks! |
|
Thanks for testing, I do need the feedback! I believe i have been using local paths for some of the images so will have to change that. Any chance you can check what path it is using? Should be in your inspector or something (right click -> inspect element on chrome). I'll look into the compact mode error, although it seems weird for it to happen only in compact mode. Can you try clicking the same movie in regular mode and see if it works? Cheers. |
|
No problem... Happy to help. The compact mode error is gone (?) for some reason.... The missing image issue:
Thanks in advance, UPDATE: the following line url works (with the '/') |
|
@gugahoi: if you're happy with this, merge it in. I've been so super-lame recently with the updates, I've had so little time. If we need to change things then we can always do so at a later date. Basically, I trust your judgement with this one, so if you're happy that the CouchPotato module is good-to-go, let's get it on master! |
|
@gugahoi : I changed the path in templates\couchpotato_all.html and templates\couchpotato.html... Can you check? Thanks in advance, |
|
@mvanderberg Ye the pull request worked fine. I've just been a bit busy the last few days. I havent had the chance to test @N3MIS15 stuff either but I think that will be the way to go. If there is a significant performance drop (which I find unlikely), I will try to find a workaround. |
| @@ -177,3 +177,6 @@ | |||
| cursor: pointer; | |||
| opacity: 1; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
why are there changes here?
|
Https support is missing while option can be enabled on the settings page. Fixed it in #180 |
Finally I am happy with this. There is room to improve and features to add but the core of it is there. Not so sure of the settings cog I added, @N3MIS15 's implementation might be better where log, restart and shutdown only appear in settings mode.